Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing lots of issues with schemas #316

Merged
merged 18 commits into from
Oct 7, 2024
Merged

Fixing lots of issues with schemas #316

merged 18 commits into from
Oct 7, 2024

Conversation

sven-oly
Copy link
Collaborator

@sven-oly sven-oly commented Sep 28, 2024 •
edited by echeran
Loading

Fix #173

  • Ensure that we have schemas for the test file and verify file for all components (the set wasn't complete)
  • Validate the schema files themselves in code
  • Validate the test result data against the "result schema"
  • Validate the test input data against the "test schema"
  • Update the display on the main summary page to be succinct and correct

@sven-oly
Copy link
Collaborator Author

I found that some schema were missing and others weren't being processed. Also, the output in the main page is much improved.

echeran
echeran reviewed Sep 30, 2024
View reviewed changes
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/schema_validator.py Outdated Show resolved Hide resolved
echeran
echeran reviewed Oct 2, 2024
View reviewed changes
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/schema_validator.py Outdated Show resolved Hide resolved
schema/schema_files.py Outdated Show resolved Hide resolved
schema/schema_files.py Outdated Show resolved Hide resolved
@sven-oly
Copy link
Collaborator Author

sven-oly commented Oct 3, 2024

Removed non-schema stuff from this PR

echeran
echeran reviewed Oct 4, 2024
View reviewed changes
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/check_test_output.py Outdated Show resolved Hide resolved
schema/schema_validator.py Show resolved Hide resolved
schema/schema_validator.py Outdated Show resolved Hide resolved
schema/schema_validator.py Show resolved Hide resolved
schema/schema_validator.py Show resolved Hide resolved
schema/schema_validator.py Show resolved Hide resolved
@sven-oly
Copy link
Collaborator Author

sven-oly commented Oct 7, 2024

PTAL!

echeran
echeran approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schema/schema_validator.py Outdated Show resolved Hide resolved
schema/schema_validator.py Outdated Show resolved Hide resolved
@sven-oly sven-oly merged commit ee6d46e into unicode-org:main Oct 7, 2024
5 checks passed
@echeran echeran changed the title Issue #173 Fixing lots of issues with schemas Fixing lots of issues with schemas Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran echeran approved these changes

Assignees

@echeran echeran

@sffc sffc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix schema messages on main page
3 participants
@sven-oly @echeran @sffc